Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default registry value is not "" but v1RegistryURL #47

Merged
merged 2 commits into from Apr 4, 2022
Merged

Default registry value is not "" but v1RegistryURL #47

merged 2 commits into from Apr 4, 2022

Conversation

ymage
Copy link
Contributor

@ymage ymage commented Apr 4, 2022

When registry is the default official docker value, return repo only

@ymage
Copy link
Contributor Author

ymage commented Apr 4, 2022 •
edited

I restored the registry == "" evaluation to pass the test but it seems registry get as default value v1RegistryURL and can never be empty.
Is this test relevant ?

@shubham149 shubham149 merged commit ea64d40 into drone:main Apr 4, 2022
@ymage ymage deleted the fix_official_docker_registry branch April 4, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham149 shubham149 shubham149 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ymage @shubham149