New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making prepend of registry url to repo name optional #48

Merged

shubham149 merged 2 commits into main from expand_repo

Apr 5, 2022

Contributor

shubham149 commented Apr 5, 2022 •

edited

PR #40 added prepending of registry url to repo name. But there are some missing cases present:

If registry URL is public dockerhub, the full repo name: index.docker.io//: but this change generates repo name as https://index.docker.io/v1//:latest. Also, it needs to handle repo's without dockerhubUsr e.g. alpine image.
https:// is usually present in the registry url but should not be mentioned in the repo name.
Some registry url's include version number which should not be present in repo name.

Hence, this will make prepending of registry url to repo name optional by introducing a field expand_repo which is by default false.


          Making prepend of registry url to repo name optional

f2aa781

shubham149 mentioned this pull request

fix: Build.Repo and Build.CacheRepo now uses buildRepo() #40

Merged


          Fix UTs

shubham149 merged commit c39a115 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment