Add configurable response code meters #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
FYI - @joschi Hoping this approach is acceptable and can be included in the upcoming release 🙂 |
joschi
force-pushed
the
Add-configurable-response-code-meters
branch
from
fef41ed
to
2a72b7c
Compare
This was referenced Feb 22, 2023
|
@joschi - Thanks for the review and accepting the changes. Should we be concerned about this - dropwizard/metrics#3179 (Fix potential NPE in InstrumentedResourceMethodApplicationListener) |
|
This PR specifically that bumps the metric version to 4.2.16 which contains the bug - #6693 Wanted your thoughts on releasing a new version of the metrics library which should include the fix. |
|
@dennyac We'll wait with a release of Dropwizard 2.1.5 until Dropwizard Metrics has been bumped to https://github.com/dropwizard/metrics/releases/tag/v4.2.17. |
|
Sounds good. Thanks. Was just checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently we only have top level 1xx/2xx/3xx/4xx/5xx meters at the jetty level. We have many use cases where we care about specific response codes like 401/503 and resort to manually instrumenting responses from every resource. This PR allows users to configure what response code meters to include.
Solution:
With the new release of metrics (since 4.2.16), we can specify what response code meters to include. Exposed the same via
AbstractServerFactory. Additionally allowed specifying themetricPrefixto include for jetty metricsResult:
To maintain backward compatibility the default behavior remains the same with this change. Users will have to explicitly specify the DETAILED/ALL responseMeteredLevel if they want more response code meters.