Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logback-access from the core framework #8073

Draft
wants to merge 4 commits into
base: release/5.0.x
Choose a base branch
from

Conversation

zUniQueX
Copy link
Member

As mentioned in this comment we could/should think of dropping support for logback-access. Logback doesn't support Jetty 12 yet and the related issue hasn't received comments for about two months.

This PR is meant to show the consequences of removing the logback-access dependency from the core framework modules.
The LogbackAccessRequestLogFactory will be removed and LogbackClassicRequestLogFactory will be the new default.

The JSON logging related access-json layout will be removed too.

I've further evaluated what it would look like supporting logback-access without the hard dependency in dropwizard-request-logging and dropwizard-json-logging. We currently have a workaround to get the LogbackAccessRequestLog working again, so we could lower the migration costs with supporting the workaround for some time (then preferably in a separate repo which will be deprecated directly). A necessary precondition for that is introducing the ServerCustomizer interface to allow customizations of the Jetty handler chain.

@zUniQueX zUniQueX added the task label Dec 19, 2023
@zUniQueX
Copy link
Member Author

zUniQueX commented Jan 2, 2024

@dropwizard/committers I've come back to this one and don't have a strong opinion on distributing the separate artifact or not. Personally, I don't like introducing the ServerCustomizer.

Feel free to share your opinions, I'll update the PR accordingly.

@zUniQueX
Copy link
Member Author

zUniQueX commented Apr 6, 2024

@dropwizard/committers The logback team recently pushed a release of logback-access with Jetty 12 compatibility in a new repo. Shall I close this PR if we get further updates or should we move away from logback-access anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant