Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JVM] Fix maximum/total memory calculation #3125

Merged
merged 3 commits into from Feb 12, 2023
Merged

[JVM] Fix maximum/total memory calculation #3125

merged 3 commits into from Feb 12, 2023

Conversation

the-thing
Copy link
Contributor

Fixes #2609

Changes

  • when max non-heap memory is undefined then total.max is equal to -1
  • when max non-heap memory is undefined then "non-heap.usage" ratio is non-heap.used / non-heap.commited (instead of non-heap.used / non-heap.max - similar to memory pools usage calculation)

@the-thing the-thing requested review from a team as code owners January 24, 2023 12:29
@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2023

@joschi joschi self-assigned this Feb 12, 2023
joschi
joschi approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-thing Thank you for your contribution!

@joschi joschi changed the title Fixed total maximum memory calculation [JVM] Fix maximum/total memory calculation Feb 12, 2023
@joschi joschi merged commit f5a6c5c into dropwizard:release/4.2.x Feb 12, 2023
@the-thing the-thing deleted the 2609/total_max_memory_calculated_incorrectly branch February 15, 2023 10:43
@LuciferYang LuciferYang mentioned this pull request Mar 3, 2023
Closed
srowen pushed a commit to apache/spark that referenced this pull request Mar 6, 2023
@LuciferYang @srowen
[SPARK-42654][BUILD] Upgrade dropwizard metrics 4.2.17
4b8b368 
### What changes were proposed in this pull request?
This pr aims upgrade dropwizard metrics to 4.2.15.

### Why are the changes needed?
The new version bring some bug fix:

- dropwizard/metrics#3125
- dropwizard/metrics#3179

And the release notes as follows:

- https://github.com/dropwizard/metrics/releases/tag/v4.2.16
- https://github.com/dropwizard/metrics/releases/tag/v4.2.17

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass Github Actions

Closes #40254 from LuciferYang/SPARK-42654.

Lead-authored-by: yangjie01 <yangjie01@baidu.com>
Co-authored-by: YangJie <yangjie01@baidu.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
@SteNicholas SteNicholas mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jvm.memory.total.max calculated incorrectly
2 participants
@the-thing @joschi