Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of scheduler #3132

Merged
merged 4 commits into from Feb 9, 2023
Merged

Allow override of scheduler #3132

merged 4 commits into from Feb 9, 2023

Conversation

dkaukov
Copy link
Contributor

@dkaukov dkaukov commented Jan 30, 2023

This is addition to the #2931 Basically, to override getScheduledFuture, we need access to the executor

@dkaukov
Allow override of scheduler
6d00e57 
Passing executor as parameter
@dkaukov dkaukov requested review from a team as code owners January 30, 2023 01:36
@gitpod-io
Copy link

gitpod-io bot commented Jan 30, 2023

joschi
joschi requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkaukov Thanks for your contribution! Since we want to avoid breaking changes in minor or patch versions, please address the requested change. 😄

metrics-core/src/main/java/com/codahale/metrics/ScheduledReporter.java Show resolved Hide resolved
@joschi joschi self-assigned this Feb 7, 2023
@dkaukov dkaukov requested a review from joschi February 9, 2023 13:54
@joschi joschi added this to the 4.2.16 milestone Feb 9, 2023
@joschi joschi merged commit 47f9eaf into dropwizard:release/4.2.x Feb 9, 2023
@dkaukov dkaukov deleted the scheduler-override-add-executor branch February 13, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
improvement
Projects
None yet
Milestone
4.2.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkaukov @joschi