Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named parameters with Cursor and Connection objects #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

austenLacy
Copy link

@austenLacy austenLacy commented Apr 27, 2021

Closes: #232

Rather than rely on correct parameter ordering, this change switches to using named parameters to avoid out of order parameters.

This bug resulted in having to do this hack to get client certificate authentication working with Druid and Superset

hack (bad)

"engine_params": {
    "connect_args": {
      "proxies": "/path/to/my.cert"
    }
}

what it should be (good)

"engine_params": {
    "connect_args": {
      "ssl_client_cert": "/path/to/my.cert"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cursor object swap init for client cert and proxy
2 participants