-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Enable Patching to true #213
Set Enable Patching to true #213
Conversation
This proved to be very useful for being able to add installation profiles that require core patches. Adding it to my configuration seems to have worked very well. I think that if we find incompatible patches in the future, it is possible to add skip patches configuration on a case by case basis https://github.com/cweagans/composer-patches#ignoring-patches. |
I think this simple change should be merged. It makes a lot of sense to allow patches from included composer.json files. If the patch doesn't apply, composer recovers gracefully and ignores it. |
+1 on adding this |
+1 |
This is still relevant for 10.x and 11.x. Would need to update accordingly using separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is very good.
From https://github.com/cweagans/composer-patches/tree/1.x
Enabling this option adds a new attack vector. I think we should not be promoting this workflow. If patches are needed - the consumer project (project started from this template) should explicitly list them in own People using this project in their automated tooling and requiring this option should be adding it themselves, realising that they are taking full responsibility for this workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green from me, but we need to resolve conflicts and composer normalize.
@leymannx |
@AlexSkrypnyk – I only work in projects where this always on. That said, this template here will always install without it set, so we might just skip it. People requiring sub-packages with their own patches probably know what they do and we could leave it to them to set it themselves. |
Locking also at how few comments it got in almost 10 years, I tend to leave it out, yes. |
Closing as won't do. Consumer projects should add this setting explicitly in their |
This PR probably does want some thought beyond bug fix... lets merge. This adds 'enable-patching' = true to the extras key. This means that patches from projects will be applied. This is obviously great in many ways but it is a significant change.
Example of usage: https://drupal.org/project/field_states_ui is applying a patch to core so as to be able to use a hook that doesn't exist, without killing kittens.