Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#462] Removed PHP version from composer.json. #649

Merged
merged 1 commit into from May 14, 2024
Merged

[#462] Removed PHP version from composer.json. #649

merged 1 commit into from May 14, 2024

Conversation

AlexSkrypnyk
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk commented May 13, 2024 •
edited

Closes #462

@AlexSkrypnyk AlexSkrypnyk self-assigned this May 13, 2024
@AlexSkrypnyk AlexSkrypnyk added PR: Needs review Pull request needs a review from assigned developers D11 labels May 13, 2024
leymannx
leymannx approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@leymannx leymannx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks nice also with that section in the README. 🤩

@leymannx leymannx self-requested a review May 14, 2024 08:32
leymannx
leymannx requested changes May 14, 2024
View reviewed changes
README.md Outdated
"platform": {
"php": "8.3.1"
}
"platform": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexSkrypnyk this is indented differently than in the other MR. Wouldn't it be better we indent it the same way in both?

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/462-11x-remove-php-versions branch from 63867f9 to e233829 Compare May 14, 2024 08:42
AlexSkrypnyk
AlexSkrypnyk commented May 14, 2024
View reviewed changes
README.md

```json
"config": {
"sort-packages": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this line as it has nothing to do with what we are trying to show here

@AlexSkrypnyk AlexSkrypnyk merged commit 7fab10d into 11.x May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leymannx leymannx Awaiting requested review from leymannx

Assignees

@AlexSkrypnyk AlexSkrypnyk

Labels
D11 PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexSkrypnyk @leymannx