Add field:create command (#4853)

* Add field:create command

* Code style

* Refactor field:create command

* Remove empty legacy command

* phpcs

* Add validators so the new annotations are functional

* Fix some issues + small refactor

- Fix issues when command is called non-interactively
- Improve handling of entity types without bundles

* Improve various prompts

* Add LinkHooks

* Apply phpcs fixes

* Add tests, and misc unrelated improvements

* PHPCS

* Try getSimplifiedErrorOutput()

* Fix UserCancelTest

* Less string

* Revert unneeded test case changes.

Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>

.ddev/config.yaml

@@ -17,4 +17,4 @@ composer_version: ""
 disable_settings_management: true
 web_environment:
   - UNISH_DB_URL=mysql://root:root@db
-  - PHP_EXTENSIONS_DISABLE=uploadprogress
+  - DRUSH_OPTIONS_URI=$DDEV_PRIMARY_URL

.ddev/web-build/Dockerfile

@@ -0,0 +1,4 @@
+# See https://stackoverflow.com/a/67092243/265501
+ARG BASE_IMAGE
+FROM $BASE_IMAGE
+RUN echo 'export PATH="$PATH:/var/www/html"' > /etc/bashrc/commandline-addons.bashrc

src/Commands/LegacyCommands.php

@@ -129,18 +129,6 @@ public function download()
     {
     }
 
-    /**
-     * field-create has been removed. Please try `generate field` command.
-     *
-     * @command field:create
-     * @aliases field-create
-     * @hidden
-     * @obsolete
-     */
-    public function field()
-    {
-    }
-
     /**
      * core:execute has been removed. Please try `site:ssh` command.
      *

src/Commands/ValidatorsCommands.php

@@ -12,7 +12,6 @@
  */
 class ValidatorsCommands
 {
-
     /**
      * Validate that passed entity names are valid.
      * @see \Drush\Commands\core\ViewsCommands::execute for an example.