Skip to content

Commit

Permalink
Add back semver_example test on highest. (#5031)
Browse files Browse the repository at this point in the history
* Add back semver_example test on highest.

* 3.0

* Bring back CI for highest
  • Loading branch information
weitzman committed Jan 25, 2022
1 parent 25b52ff commit 8a1b0ad
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 16 deletions.
2 changes: 0 additions & 2 deletions .circleci/config.yml
Expand Up @@ -123,8 +123,6 @@ jobs:
- run: php --version
- run: composer -n config platform.php --unset
- run: composer -n require --dev drupal/core-recommended:10.0.x-dev --no-update
# Bring it back when it is compatible with Drupal 10.
- run: composer -n remove drupal/semver_example --no-update --dev
- run: composer -n update
- run: mkdir -p /tmp/results
- run: composer -n lint
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -58,7 +58,7 @@
"cweagans/composer-patches": "~1.0",
"david-garcia/phpwhois": "4.3.0",
"drupal/core-recommended": "^9 || ^10",
"drupal/semver_example": "2.2.0",
"drupal/semver_example": "2.3.0",
"phpunit/phpunit": ">=7.5.20",
"rector/rector": "^0.12",
"squizlabs/php_codesniffer": "^3.6",
Expand Down
22 changes: 13 additions & 9 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions tests/integration/SecurityUpdatesTest.php
Expand Up @@ -16,10 +16,7 @@ class SecurityUpdatesTest extends UnishIntegrationTestCase
*/
public function testInsecureDrupalPackage()
{
if (Semver::satisfies(\Drupal::VERSION, '^10')) {
$this->markTestSkipped('drupal/semver_example not yet compatible.');
}
list($expected_package, $expected_version) = ['drupal/semver_example', '2.2.0'];
list($expected_package, $expected_version) = ['drupal/semver_example', '2.3.0'];
$this->drush('pm:security', [], ['format' => 'json'], self::EXIT_ERROR_WITH_CLARITY);
$this->assertStringContainsString('One or more of your dependencies has an outstanding security update.', $this->getErrorOutput());
$this->assertStringContainsString("$expected_package", $this->getErrorOutput());
Expand Down

0 comments on commit 8a1b0ad

Please sign in to comment.