Make config.storage.sync injection optional and log any issues

drush-ops · Aug 13, 2022 · 9d50715 · 9d50715
1 parent 91ee2b5
commit 9d50715
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/src/Drupal/Commands/config/ConfigCommands.php b/src/Drupal/Commands/config/ConfigCommands.php
@@ -2,6 +2,7 @@
 
 namespace Drush\Drupal\Commands\config;
 
+use Drupal\Core\Config\ConfigDirectoryNotDefinedException;
 use Drupal\Core\Config\ImportStorageTransformer;
 use Consolidation\AnnotatedCommand\CommandError;
 use Consolidation\AnnotatedCommand\CommandData;
@@ -389,7 +390,10 @@ public static function getDirectory($directory = null): string
             }
         } else {
             // If a directory isn't specified, use default sync directory.
-            $return = Settings::get('config_sync_directory');
+            $return = Settings::get('config_sync_directory', false);
+            if ($return === false) {
+                throw new ConfigDirectoryNotDefinedException('The config sync directory is not defined in $settings["config_sync_directory"]');
+            }
         }
         return Path::canonicalize($return);
     }

diff --git a/src/Drupal/Commands/config/ConfigExportCommands.php b/src/Drupal/Commands/config/ConfigExportCommands.php
@@ -68,17 +68,21 @@ public function getConfigStorageSync(): StorageInterface
         return $this->configStorageSync;
     }
 
+    public function setConfigStorageSync(?StorageInterface $syncStorage): void
+    {
+        $this->configStorageSync = $syncStorage;
+    }
+
     /**
      * @param ConfigManagerInterface $configManager
      * @param StorageInterface $configStorage
      * @param StorageInterface $configStorageSync
      */
-    public function __construct(ConfigManagerInterface $configManager, StorageInterface $configStorage, StorageInterface $configStorageSync)
+    public function __construct(ConfigManagerInterface $configManager, StorageInterface $configStorage)
     {
         parent::__construct();
         $this->configManager = $configManager;
         $this->configStorage = $configStorage;
-        $this->configStorageSync = $configStorageSync;
     }
 
     /**

diff --git a/src/Drupal/Commands/config/ConfigImportCommands.php b/src/Drupal/Commands/config/ConfigImportCommands.php
@@ -81,6 +81,11 @@ public function getConfigStorageSync(): StorageInterface
         return $this->configStorageSync;
     }
 
+    public function setConfigStorageSync(StorageInterface|null $syncStorage): void
+    {
+        $this->configStorageSync = $syncStorage;
+    }
+
     public function getConfigCache(): CacheBackendInterface
     {
         return $this->configCache;
@@ -164,7 +169,6 @@ public function getModuleExtensionList(): ModuleExtensionList
     public function __construct(
         ConfigManagerInterface $configManager,
         StorageInterface $configStorage,
-        StorageInterface $configStorageSync,
         CacheBackendInterface $configCache,
         ModuleHandlerInterface $moduleHandler,
         // Omit type hint as it changed in https://www.drupal.org/project/drupal/issues/3161983
@@ -179,7 +183,6 @@ public function __construct(
         parent::__construct();
         $this->configManager = $configManager;
         $this->configStorage = $configStorage;
-        $this->configStorageSync = $configStorageSync;
         $this->configCache = $configCache;
         $this->moduleHandler = $moduleHandler;
         $this->eventDispatcher = $eventDispatcher;

diff --git a/src/Drupal/Commands/config/drush.services.yml b/src/Drupal/Commands/config/drush.services.yml
@@ -10,17 +10,17 @@ services:
       -  { name: drush.command }
   config.export.commands:
     class: \Drush\Drupal\Commands\config\ConfigExportCommands
-    arguments: ['@config.manager', '@config.storage', '@config.storage.sync']
+    arguments: ['@config.manager', '@config.storage']
     calls:
       - [setExportStorage, ['@?config.storage.export']]
+      - [setConfigStorageSync, ['@?config.storage.sync']]
     tags:
       -  { name: drush.command }
   config.import.commands:
     class: \Drush\Drupal\Commands\config\ConfigImportCommands
     arguments:
       - '@config.manager'
       - '@config.storage'
-      - '@config.storage.sync'
       - '@cache.config'
       - '@module_handler'
       - '@event_dispatcher'
@@ -32,5 +32,6 @@ services:
       - '@extension.list.module'
     calls:
       - [setImportTransformer, ['@?config.import_transformer']]
+      - [setConfigStorageSync, ['@?config.storage.sync']]
     tags:
       -  { name: drush.command }