Stop prepending the Cancel option to choice lists #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancel is explicit. If you press [RETURN], the default option will be cancel. Existing Drush users are used to seeing the cancel option. I don't see the benefit of removing this. |
|
I do see some benefit. It gets tedious to see these on a long wizard like field:create. Also, drush generate command does not do this. Still mulling this. |
|
Sure, go ahead if you prefer. Maybe reserve 0 for cancel but don't print it as a compromise? Still slightly prefer keeping cancel in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4907.