Add field:base-override-create command #4929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2021
Merged
weitzman
reviewed
Dec 15, 2021
| /** | ||
| * Create a new base field override | ||
| * | ||
| * @command base-field:override-create |
There was a problem hiding this comment.
I think we want this in the field: namespace so it groups with the others in help list.
It's a Drupal core feature so I thought it would be an added value here, but I understand your point. I use it regularly, for example to make base fields optional/required for certain bundles or to change labels/descriptions. If you think this doesn't belong in Drush core, feel free to close the MR. |
DieterHolvoet
force-pushed
the
base-field-override-create
branch
2 times, most recently
from
15309ed
to
e432413
Compare
DieterHolvoet
force-pushed
the
base-field-override-create
branch
from
584b281
to
35fb410
Compare
+ fix renamed traits + make entityType argument optional
DieterHolvoet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command to create a base field override. It has already been used in multiple projects as part of the wmscaffold module and is in my opinion stable enough to be considered to be merged in Drush.
Remarks
AskBundleTraitandValidateEntityTypeTraitare also included in Add field:delete command #4926, Add field:info command #4928 and Add field:base-info command #4930.Test scenarios
./vendor/bin/drush bfoc=> Not enough arguments (missing: "entityType")../vendor/bin/drush bfoc node=> Asks for bundle./vendor/bin/drush bfoc node --no-interaction=> The bundle argument is required../vendor/bin/drush bfoc node article=> Asks for field name./vendor/bin/drush bfoc node article --no-interaction=> The field-name option is required../vendor/bin/drush bfoc node article --no-interaction --field-name=title=> Successfully created base field override 'title' on node with bundle 'article' (with existing values), if the field doesn't exist Base field with name 'some_name' does not exist on bundle 'article'../vendor/bin/drush bfoc node article --field-name=title --field-label="Better title" --is-required=0=> Successfully created base field override 'title' on node with bundle 'article' (with passed values)TODO