Add archive:dump command
#5048
Add archive:dump command
#5048
Conversation
jabxjab
changed the title
archive:dump command for a Composer-managed and "web" docroot-based sitearchive:dump command
Create database.tar sub-archive; Create files.tar sub-archive; Create master archive.tar.gz
…json in "extra"/"installer-paths" section
jabxjab
force-pushed
the
archive-dump-command
branch
from
33c8aae
to
650a372
Compare
jabxjab
force-pushed
the
archive-dump-command
branch
10 times, most recently
from
24c311a
to
37c209c
Compare
jabxjab
force-pushed
the
archive-dump-command
branch
from
37c209c
to
a486209
Compare
| public function testArchiveRestoreCommand(): void | ||
| { | ||
| // @todo: remove once archive:restore command has added. | ||
| if (!class_exists('\Drush\Commands\core\ArchiveRestoreCommands')) { |
There was a problem hiding this comment.
archive:restore command is here - #5095
…--files", "--files_path" options
| $this->filesystem = new Filesystem(); | ||
| $this->archiveDir = Path::join(FsUtils::prepareBackupDir(self::ARCHIVES_DIR_NAME), self::ARCHIVE_SUBDIR_NAME); | ||
| $this->filesystem->mkdir($this->archiveDir); | ||
| register_shutdown_function([$this, 'cleanUp']); |
There was a problem hiding this comment.
@weitzman: Drush 8 had a number of convenience methods related to temporary files and directories which were automatically cleaned up in Drush's shutdown handler. These were primarily used by make and pm commands, which are no longer part of Drush. Config import and rsync used to use them in Drush 8, but do not in Drush 11. What are your thoughts on direct use of register_shutdown_function() for cleanup in light of the lack of this service in Drush 11? Is this the best practice for commands that want cleanup on termination?
|
Drush tests are green again if 11.x branch is merged in, as was done in #5148. The problem with the appveyor build started happening recently; tried to find a fix, but couldn't. Downloading the cacert works locally, the problem seems to be with the supported TLS methods in the appveyor image not being up-to-date enough to talk to the providing server as of a week or two ago. |
|
Fixed in #5148 |
Related PR #5095