New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on Drupal 10 #5054
Fix tests on Drupal 10 #5054
Conversation
bc1bf52
to
cc4ae54
Compare
I fixed one problem, but couldn't push it to your branch. You can see the change at e3acd1c. The next error after this one might be in the Annotated Command library; null is being passed to |
I tried the same fix you made but I was seeing that $this->getStream() and $this->consoleSectionOutputs are not defined. Needs more research. I'm gonna merge what I have in a few mins. |
|
||
public function section(): ConsoleSectionOutput | ||
{ | ||
// @todo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can copy the implementation from Symfony, as I did in e3acd1c
PR for setHelp() call - consolidation/annotated-command#261 |
* 11.x: (125 commits) Add a default value for the field widget choice in field:create (drush-ops#5060) Fix drush-ops#5058. Load/delete entities that are access controlled. (drush-ops#5059) Ignore services on invalid reference (drush-ops#5056) Fix tests on Drupal 10 (drush-ops#5054) Fix usage example in core:route command (drush-ops#5053) Back to dev. Prep for 11.0.4 Update SecurityUpdateCommands endpoint (drush-ops#5043) Remove drush_get_global_options() (drush-ops#5046) Remove unused global options remote-host and remote-user. (drush-ops#5045) sql:sync minor cleanup (drush-ops#5044) Add back semver_example test on highest. (drush-ops#5031) Return values instead of keys in discoverCommandsFromConfiguration. (drush-ops#5039) Back to dev. Prep for 11.0.3 Dont define entity-updates (drush-ops#5038) Back to dev. Prep for 11.0.2 Remove dead code and re-enbale --partial test. (drush-ops#5036) Bump site-process for less verbose exceptions. (drush-ops#5034) ... Merge conflicts - src/Drupal/Commands/core/drush.services.yml
No description provided.