Remove psr/log as direct dependency #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chi-teck/drupal-code-generator is still holding us back to psr/log ^1. Consolidation components + grasmash/expander will now allow psr/log ^2. I didn't notice that there was a prs/log ^3, despite the comment "or v3" above. 🤦 |
|
It looks like we'll need a major version bump of at least consolidation/log to get to psr/log ^3. Maybe that's the only component. Drupal is only at ^2 at the moment, so it's not critical to allow ^3, but it would be good to do ahead of Drupal if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.drupal.org/node/3266017. Various consolidation components need psr/log v2 or v3 compat before drush's
test_81_drupal10_highesttests will pass.