The field:delete command deletes fields from all bundles instead of only the requested bundles. #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this since test failures are unrelated. |
DieterHolvoet
deleted the
5157-the-fielddelete-command-deletes-fields-from-all-bundles-instead-of-only-the-requested-bundles
branch
greg-1-anderson
pushed a commit
that referenced
this pull request
Jun 23, 2022
* field-delete: Fix field being deleted from all bundles instead of only the requested bundle (#5158) * Updates input default options and provides destination validation. * Removes automatic composer install and adds user feedback. * Resolves phpcs feedback. * Adds composer install to test to allow Drupal installation. * Resolves code sniff. * Adds needed class. * Runs composer update to resolve security warnings. * Updates guzzle version. Co-authored-by: Dieter Holvoet <dieter.holvoet@gmail.com> Co-authored-by: Ryan Wagner <ryan.wagner@pantheon.io>
greg-1-anderson
added a commit
that referenced
this pull request
Jul 7, 2022
* Add ArchiveCommands.php
* Add SQL dump operation
* Add "description", "tags", "destination" and "overwrite" options to annotation
* Refactor getDrupalFilesDir();
Create database.tar sub-archive;
Create files.tar sub-archive;
Create master archive.tar.gz
* Refactor creating database and file archives
* Add createMasterArchive()
* Add createManifestFile()
* Rename "db_dump" option into "db"
* Update default generator value
* Add "--destination" and "--overwrite" options
* Update info messages
* Log info when creating manifest file
* Remove "master" archive mentions in logs
* Refactor archive structure ("database" and "files" are now directories)
* Add "code" component
* Add getExcludesByPaths()
* Refactor code excludes
* Exclude css, js, php and styles from file component
* Exclude from code archive everything from web/ except modules, themes, profiles
* Refactor Drupal contrib projects excludes
* Exclude sites/*/settings.local.php from code archive
* Add validateSensitiveData()
* Remove todo
* Fix method name
* Fix getCodeComponentPath()
* Rename getCodeComponentPath() into getProjectPath()
* Add site validation
* Update command description
* Fix validateSite()
* Add ArchiveTest
* Fix code style issues
* Add support for non-Composer managed, non-web docroot sites
* Fix command for non-web docroot sites
* Exclude settings.*.php
* Fix testArchiveDumpCommand() test
* Add cleanUp() shutdown function
Use Symfony Filesystem component
* Copy code archive component to archive dir
* Use constants for archive component names
* Refactor excludes
* Simplify cleanUp()
* Rename constants
* Rename getExcludesByPaths() into getRegexpsForPaths()
* Update phpdocs
* Rename var
* Use Path::join()
* Use array_map in getRegexpsForPaths()
* Rename getIterator()
* Fix missing manifest file
* Return absolute path to the archive
* Delete temp archive.tar.gz if exists
* Add scenarios to testArchiveDumpCommand()
* Fix code style issues
* Fix testArchiveDumpCommand()
* Rename ArchiveDumpCommands and refactor getDrupalFilesComponentPath()
* Remove setSimulated()
* Set php memory_limit to 256M in appveyor.yml
* Fix file iterator local file path handling
* Remove unused constants
* Create temp dir on command execution only
* Add ArchiveRestoreCommands backbone
* Add confirmation prompts
* Implement extractArchive()
* Add check for file existence
* Add check for filename extension
* Add todo
* Import code file for a local target only
* Import code files for a remote targets
* Add 'docroot' property to the manifest file
* Fix $aliasConfigContext
* Fix nested php includes in validateSensitiveData()
* Bootstrap Drupal core to get a path to Drupal public files
* Disable type3/phar-stream-wrapper which loads with Drupal core and prevents creating *.tar archives
* Fix getDrupalFilesComponentPath()
* Remove Site Alias manager
* Refactor validateSensitiveData() to include site/*/settings.php file without include/require directives
* Fix scenario when backup dir is inside code dir (and on Windows OS)
* Fix scenario when backup dir is inside code dir (and on Windows OS) using \Webmozart\PathUtil\Path util
* Fix getCodeComponentPath()
* Improve verbosity in validateSensitiveData()
* Add dt() to Exception messages
* Refactor Drupal-related excludes - exclude paths defined in composer.json in "extra"/"installer-paths" section
* Detect Drupal files exclude for code component
* Use 'composer info --path --format=json' to exclude packages installation paths
* Add "composer" as alias to "php composer.phar" in appveyor.yml
* Rename $installedPackagesBaseDirs into $installedPackagesRelativePaths
* Use native Symfony\Process for "composer info" command execution
* Add '%composer-root' to core:status command
* Add 'composer-root' to @field-labels/@default-fields of core:status command
* Detect composer root for a remote site
* Add rsyncFiles()
* Add importFiles()
* Add getSiteAlias(), getSiteStatus()
* Fix $evaluatedPath instantiation for a remote site
* Detect composer root for a remote site
* Add rsyncFiles()
* Add importFiles()
* Add getSiteAlias(), getSiteStatus()
* Fix $evaluatedPath instantiation for a remote site
* Add blueprint of importDatabase()
* Update importDatabase()
* Fix todos
* Fix code style issues
* Add testArchiveRestoreCommand() to ArchiveTest
* Add test scenario for "--overwrite" option
* Add test scenario for "--code", "--code_path", "--db", "--db_path", "--files", "--files_path" options
* PROPOSAL: Replace direct use of register_shutdown_function with Robo _tmpDir() facility.
* Proposal 2: Provide our own tmpDir service in FsUtils
* Code style
* Simplify tests: do one less archive:dump, and instead use file_put_contents to test with and without --overwrite.
* Update download url of cacert to new location
* Try curl instead of DownloadFile
* Skip tests of unsupported configurations
* Remove eval() from validateSensitiveData()
* Remove support for a remote site for archive:restore command
* Add an option to restore code into current dir if empty
* Remove ssh-related option
* Add --destination_path option
* Rename archive:restore options
* Do not check $destination dir (creates automatically by rsync)
* Throw exception on Drupal bootstrap failure when getting Drupal files path
* Add archive:restore options: db-name, db-port, db-host, db-user, db-password, db-prefix, db-driver
* Replace underscores with dashes in option names
* Update tests for archive:restore
* Remove $autodetectDestination
* Fix indentations
* Disable SecurityUpdatesTest.php temporarily
* Require database connection option(s) when --destination-path options is provided
* Add support for relative paths in --destination-path option
* Add test scenarios for testArchiveRestoreCommand()
* Set sut db password to empty string
* Use self::getDbUrl() to construct --db-url
* Add tearDown() to delete a test file
* Update testing scenario to use invalid db host instead of password
* Add --db-driver option in tests
* Add testing scenarios for database component involving --destination-path option
* Revert "Disable SecurityUpdatesTest.php temporarily"
This reverts commit f7e66e9.
* Allow archive:restore to extract archive and files to cwd. Improve FsUtils::tmpDir, and use it in archive:restore. Add default options to sut to avoid including Drush sources in archive:dumps of the sut, for more convenient ad-hoc testing.
* Code style
* WIP: Avoid overwriting sut in archive restore tests
* Fix var name typo
* Remove unused namespace, @throws tag and $root var
* Remove unused namespaces and ARCHIVE_SUBDIR_NAME const
* Refactor extractArchive() into getExtractDir()
* Create database if not exists database import
* Remove duplicated testing scenarios
* Update archive:restore tests
* Remove tearDown()
* Use setDbSpec() before calling query() in ArchiveRestoreCommands::importDatabase()
* Fix drop/create db in importDatabase()
* Remove escaping "\" in --exclude-code-paths
* Add composer.json and composer.lock to a SUT's archive
* Run 'composer install' after archive:restore in testArchiveRestoreCommand()
* Manage SUT's settings.php file
* Refactor settings.php file setup procedures
* Remove unused arg
* Delete destination directory in case when code component is involved and add a confirmation dialog
* Add confirmation dialog for Drupal files restore if destination path already exists and --overwrite is not set
* Fix tests
* Show prompt on file import if Drupal files dir exists and one of --code or --overwrite option is not set
* Refactor setupSettingsPhp()
* Refactor backupSettingsPhp()
* Add installComposerDependencies()
* Add assertRestoredSiteStatus()
* Remove "composer install" code in favor of the method
* Remove excessive assertion
* Add "composer install" to testArchiveRestoreCommand()
* Change $filesRelativePath to a real value
* Assert the restored site is OK
* Add more assertions that the restored site is OK
* Update dependencies to fix testNoInsecureProductionPhpPackage failure.
* Remove "composer install" from tests
* Rename "destination path" property/method name
* Add --code-no-composer-install and --code-composer-install-timeout options
* Add "composer install" to importCode()
* Remove setupSettingsPhp() and backupSettingsPhp() from tests
* Add --site-subdir and --setup-database-connection options
* Add getDrupalRootPath()
* Update $options default value
* Add setupLocalSettingsPhp()
* Update testArchiveRestoreCommand()
* Fix code style issue
* Add saveSettingsLocalPhp()
* Add database connection settings to settings.local.php file
* Update dependencies to fix testNoInsecureProductionPhpPackage failure.
* Fix null command references (in service commands list) during Drupal bootstrap phase (which causes "PHP Fatal error: Cannot redeclare drupal_error_levels() (previously declared in..." in test_81_drupal10_highest CI pipeline)
* Jabxjab archive dump command updates (#5165)
* field-delete: Fix field being deleted from all bundles instead of only the requested bundle (#5158)
* Updates input default options and provides destination validation.
* Removes automatic composer install and adds user feedback.
* Resolves phpcs feedback.
* Adds composer install to test to allow Drupal installation.
* Resolves code sniff.
* Adds needed class.
* Runs composer update to resolve security warnings.
* Updates guzzle version.
Co-authored-by: Dieter Holvoet <dieter.holvoet@gmail.com>
Co-authored-by: Ryan Wagner <ryan.wagner@pantheon.io>
* Validate that the Phar extension is available
* Remove class phpdoc descriptions
* Remove unused "use" statement
* Remove --code-no-composer-install and --code-composer-install-timeout options
* Remove @var phpdocs on explicitly declared class properties
* Add @Usage examples for archive:restore
* Add @Usage examples for archive:dump
* Validate "rsync" exists for archive:restore command
Co-authored-by: Sergei Churilo <sergei.churilo@pantheon.io>
Co-authored-by: Sergei Churilo <jabxjab@gmail.com>
Co-authored-by: J Ryan Wagner <jryanwagner00@gmail.com>
Co-authored-by: Dieter Holvoet <dieter.holvoet@gmail.com>
Co-authored-by: Ryan Wagner <ryan.wagner@pantheon.io>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5157.