Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 compatibility: upgrade webmozarts/assert to 1.11.0 #5169

Merged
merged 1 commit into from Jun 23, 2022

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Jun 22, 2022

Part of #5168 (comment)

PHP Deprecated:  Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973
PHP Deprecated:  Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973
PHP Deprecated:  Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973
PHP Deprecated:  Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973

Deprecated: Use of "static" in callables is deprecated in /var/www/html/web/vendor/webmozart/assert/src/Assert.php on line 1973

@greg-1-anderson
Copy link
Member

The Unish\SecurityUpdatesTest::testNoInsecureProductionPhpPackage failure usually goes away if you just run a general composer update to update all of the dependencies in the lock file.

@andypost
Copy link
Contributor Author

@greg-1-anderson is it ok to update all dependencies?

@weitzman
Copy link
Member

Its OK, but there is a chance your PR will need a reroll if #5165 gets in first. That also updates all.

@andypost
Copy link
Contributor Author

Than would be great to create new releases for Consolidation components and reroll this one

@andypost
Copy link
Contributor Author

@greg-1-anderson
Copy link
Member

Merged the consolidation PRs; will make releases in a bit.

@greg-1-anderson
Copy link
Member

Also, I'm pretty sure that the composer.lock changes in #5165 are only to avoid the Unish\SecurityUpdatesTest::testNoInsecureProductionPhpPackage failure. If we merge this one first, then we can reroll the archive commands without a composer.lock change.

@greg-1-anderson
Copy link
Member

Tagged consolidation/config:2.1.1 and consolidation/annotated-command:4.5.6. I didn't turn on testing for PHP 8.2 yet, though.

@greg-1-anderson
Copy link
Member

Kind of odd that only the highest test is failing in testNoInsecureProductionPhpPackage. Didn't look into why that is; perhaps we can merge this anyway, and investigate that later?

@weitzman
Copy link
Member

That highest test installs core-recommended:10.0.x-dev and then we run a security check against that and find that guzzlehttp/guzzle is insecure. I'm not sure why. Exploring that in #5171.

@weitzman
Copy link
Member

Composer is getting us guzzle 7.4.4 which is insecure. I would think we would be getting 7.4.5.

I'm OK with merging this PR and will do so in a day or two barring any negative comments.

@weitzman
Copy link
Member

I see whats happenning https://github.com/drupal/core-recommended/blob/b7b0bc4cb7105bb329a2ec9a57c612607ec22744/composer.json#L18 is pinning us via a psr7 dependency. See https://www.drupal.org/project/drupal/issues/3291780

@weitzman weitzman merged commit 406625e into drush-ops:11.x Jun 23, 2022
@andypost andypost deleted the 11.x-assert branch June 23, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants