Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set the URL for the security advisories composer url via env variable #5180

Merged
merged 4 commits into from Jul 12, 2022
Merged

Allow to set the URL for the security advisories composer url via env variable #5180

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f92c82
Allow to set the URL for the security advisories composer url via env…
Cyberschorsch Jul 11, 2022
2005781
Improve the code getting the security advisories url by using a null …
Cyberschorsch Jul 12, 2022
711a928
Add a comment about the env variable not being a supported api.
Cyberschorsch Jul 12, 2022
e62c4fe
Fix getting either the env variable or default url
Cyberschorsch Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Commands/pm/SecurityUpdateCommands.php
View file
Open in desktop
Expand Up @@ -95,14 +95,20 @@ public function suggestComposerCommand($updates): void
/**
* Fetches the generated composer.json from drupal-security-advisories.
*
* This function fetches the generated composer.json from the
* drupal-security-advisories repository or fetches it from another source
* if the environment variable DRUSH_SECURITY_ADVISORIES_URL is set. The
* environment variable is not a supported API.
*
* @return mixed
*
* @throws \Exception
*/
protected function fetchAdvisoryComposerJson()
{
$client = new Client(['handler' => $this->getStack()]);
$response = $client->get('https://raw.githubusercontent.com/drupal-composer/drupal-security-advisories/9.x/composer.json');
$security_advisories_composer_url = getenv('DRUSH_SECURITY_ADVISORIES_URL') ?? 'https://raw.githubusercontent.com/drupal-composer/drupal-security-advisories/9.x/composer.json';
Cyberschorsch marked this conversation as resolved.
Show resolved Hide resolved
$response = $client->get($security_advisories_composer_url);
$security_advisories_composer_json = json_decode($response->getBody(), true);
return $security_advisories_composer_json;
}
Expand Down