Fix fatal error on Drupal 10 w/ symfony/console:6.2+ #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
approved these changes
Aug 19, 2022
weitzman
requested changes
Aug 19, 2022
| @@ -23,7 +23,7 @@ public function confirm(string $question, bool $default = true): bool | |||
| return parent::confirm($question, $default); | |||
| } | |||
|
|
|||
| public function choice(string $question, array $choices, mixed $default = null): mixed | |||
| public function choice(string $question, array $choices, mixed $default = null, bool $multiSelect = false): mixed | |||
There was a problem hiding this comment.
We need to pass along $multiSelect in the parent::choice call a few lines down.
There was a problem hiding this comment.
🤦 fixed - to clarify this is only when we get to symfony/console 6.2
There was a problem hiding this comment.
its safe to merge this now right? its compatible with symfony 4?
There was a problem hiding this comment.
I think you have a different DrushStyle for symfony4 in the src-symfony-compatibility/v4 directory.
In terms of will it break on symfony/console: 6.1 - doesn't seem like it https://3v4l.org/ZXXWg
larowlan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Drupal 10 (with symfony/console 6.2.x) I'm getting this fatal:
This is to fix that signature difference