Ensure a string is passed to strtolower() in PmCommands::pmList()

[claudiu-cristea]

Steps to reproduce

On PHP 8.1, run:

$ ./vendor/bin/drush pml

You'll get:

[error] Message: /Deprecated function/: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Drush\Drupal\Commands\pm\PmCommands->pmList()/ (line /239/ of /vendor/drush/drush/src/Drupal/Commands/pm/PmCommands.php/).
Drush\Drupal\Commands\pm\PmCommands->pmList(Array) call_user_func_array(Array, Array) (Line: 257)>
Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback(Array, Object) (Line: 212)
...

[weitzman]

The (string) call should go inside of strtolower I think

[claudiu-cristea]

The (string) call should go inside of strtolower I think

So true 😀

[weitzman]

I dont understand it, but I think the test failure is trying to tell us something. Its in pm:list which would be quite the coincidence if its unrelated.

[claudiu-cristea]

@weitzman It's failing in \Unish\WatchdogTailTest::testWatchdogTail() which doesn't seem to run pm:list

[weitzman]

You are correct.