Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field-create/field-delete: Filter bundles according to passed field name (11.x) #5345

Conversation

DieterHolvoet
Copy link
Contributor

Fixes #5266.

@DieterHolvoet DieterHolvoet changed the title field-delete: Filter bundles according to passed field name field-create/field-delete: Filter bundles according to passed field name Dec 28, 2022
@weitzman
Copy link
Member

@DieterHolvoet Is this ready for merge?

@DieterHolvoet
Copy link
Contributor Author

I added a test case for the new all-bundles option, but I'm not sure how to add a test for this:

I'm running drush field:delete --field-name=field_state_organization_tax node and Drush is offering me to pick from bundles that don't have the field thats been passed.

@weitzman
Copy link
Member

weitzman commented Mar 1, 2023

Reminder that this needs to also be merged into 12.x branch. Thanks.

@weitzman
Copy link
Member

weitzman commented Mar 1, 2023

I'm running drush field:delete --field-name=field_state_organization_tax node and Drush is offering me to pick from bundles that don't have the field thats been passed

Yes, its hard to test interactive features. You can skip the test for this piece.

@DieterHolvoet
Copy link
Contributor Author

Okay, in that case I think this is good to go.

@DieterHolvoet DieterHolvoet merged commit a3003b0 into drush-ops:11.x Mar 1, 2023
@DieterHolvoet DieterHolvoet changed the title field-create/field-delete: Filter bundles according to passed field name field-create/field-delete: Filter bundles according to passed field name (11.x) Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect --field-name in field:delete interaction
2 participants