Fix parameter name in ConfigCommands::__constructor()

[Chi-teck]

This currently triggers the following notice on PHP 8.2.

Deprecated function: Creation of dynamic property Drush\Drupal\Commands\config\ConfigCommands::$configStorage is deprecated in Drush\Drupal\Commands\config\ConfigCommands->__construct()

[Chi-teck]

Well, I am not actually certain if the provided fix is correct. Seems like configStorage and configStorageExport are used independently.
Here is the PR where this change was introduced #4201.

[weitzman]

@bircher Thoughts?

[bircher]

No this is not correct. A more correct fix would be to explicitly define protected $configStorage. The export storage is set via an optional setter (for BC with D8.7), and the one from the constructor is the active storage. If we don't need to support Drupal 8.7 then we could use both in the constructor and clean up all of the config command classes to be more consistent

[weitzman]

Thanks. We dropped Drupal 8 compat with Drush 11 https://www.drush.org/latest/install/#drupal-compatibility. I'll close this and hopefully someone will start a new PR with cleanup as suggested.

[andypost]

++ to commit only 5a4a8c1