Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Composer Runtime API to determine Drush version #5462

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Mar 13, 2023

Drush version : 12.9999999.9999999.9999999-dev

@greg-1-anderson
Copy link
Member

Feels a bit odd, but it's documented, so I guess we can use it, and it's preferable to what we were doing before.

Could we preg_replace the 9s so that dev just comes out 12.x-dev? I understand why Composer does what it does, but I'd rather not show that as a version to the user. Unless you think folks will pass the output from drush --version version compare.

@weitzman
Copy link
Member Author

Lets leave the version as is because it gives a sensible value for \Drush\Drush::getMinorVersion. Happy to discuss more.

@weitzman weitzman merged commit 660466e into drush-ops:12.x Mar 13, 2023
@weitzman weitzman deleted the get-version-from=-composer branch March 13, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants