Static create commands #5562
Merged
Static create commands #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
requested review from
davereid,
Sutharsan,
jonhattan,
DieterHolvoet,
claudiu-cristea,
bircher and
weitzman
as code owners
|
I wasn't sure why the Sql command tests were failing after the conversion, so I reverted that part. The generators could take greater advantage of DI now, but overall I think it would be good to merge here now, move on to other things, and maybe come back to those issues later, as follow-on work. |
greg-1-anderson
requested review from
Chi-teck
and removed request for
davereid,
Sutharsan,
claudiu-cristea,
jonhattan,
bircher and
DieterHolvoet
|
I just remembered I was going to use |
weitzman
approved these changes
May 12, 2023
…ds, RoleCommands and WatchdogCommands.
…tter at all if the service is missing; will make a wrapper for this as follow-on work.
This reverts commit 5c2281d.
greg-1-anderson
force-pushed
the
static-create-commands
branch
from
41059c9
to
bb8e240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5552, rebased on top of #5553