Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drush's own service providers. #5584

Merged
merged 3 commits into from
May 23, 2023

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented May 22, 2023

I think these lines are no longer needed /cc @greg-1-anderson

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these can go!

@weitzman
Copy link
Member Author

Is there a reason why the sql commandfiles stay in /Drupal dir?

@greg-1-anderson
Copy link
Member

Yes, I tried to port them, and the tests failed. I couldn't figure out why they were breaking, seemed unrelated. Thought I would do one commandfile at a time, and see which one actually caused the problem. Haven't had time to circle back yet.

@weitzman weitzman merged commit c782fa1 into drush-ops:12.x May 23, 2023
2 checks passed
@weitzman weitzman deleted the remove-service-ymls branch May 23, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants