Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cset - allow NULL as value #5588

Merged
merged 2 commits into from
May 26, 2023
Merged

cset - allow NULL as value #5588

merged 2 commits into from
May 26, 2023

Conversation

wimleers
Copy link
Contributor

PR for #5587.

@wimleers wimleers mentioned this pull request May 26, 2023
Closed
wimleers
wimleers commented May 26, 2023
View reviewed changes
src/Commands/config/ConfigCommands.php Outdated Show resolved Hide resolved
src/Commands/config/ConfigCommands.php Outdated Show resolved Hide resolved
@weitzman weitzman merged commit 8b6ac4d into drush-ops:12.x May 26, 2023
2 checks passed
@weitzman
Copy link
Member

Welcome to Drush, @wimleers!

@T2L
Copy link

T2L commented Jun 22, 2023

this change produces

Error: ] TypeError: strtolower(): Argument #1 ($string) must be of type string, array given in strtolower() (line 175 of /vendor/drush/drush/src/Commands/config/ConfigCommands.php

when using something like ./vendor/bin/drush config:set config_ignore.settings ignored_config_entities '[]' --yes with PHP8.1+

@T2L T2L mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weitzman weitzman Awaiting requested review from weitzman

@greg-1-anderson greg-1-anderson Awaiting requested review from greg-1-anderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wimleers @weitzman @T2L