Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument/option autocompletion to field commands #5678

Merged

Conversation

DieterHolvoet
Copy link
Contributor

@DieterHolvoet DieterHolvoet commented Jun 28, 2023

I added autocompletion to the entityType/bundle arguments of the field commands. Not sure if we have a way to test these kind of things yet.

@weitzman weitzman marked this pull request as draft July 6, 2023 11:49
@DieterHolvoet DieterHolvoet changed the title WIP: Add argument autocompletion to field commands Add argument autocompletion to field commands Aug 3, 2023
@DieterHolvoet DieterHolvoet force-pushed the feature/field-command-completion branch from 538fc75 to 3b5a12b Compare August 3, 2023 14:47
@DieterHolvoet DieterHolvoet changed the title Add argument autocompletion to field commands WP: Add argument/option autocompletion to field commands Aug 4, 2023
@DieterHolvoet DieterHolvoet self-assigned this Aug 4, 2023
@DieterHolvoet DieterHolvoet removed the request for review from weitzman August 4, 2023 09:41
@DieterHolvoet DieterHolvoet changed the title WP: Add argument/option autocompletion to field commands WIP: Add argument/option autocompletion to field commands Aug 4, 2023
@DieterHolvoet DieterHolvoet changed the title WIP: Add argument/option autocompletion to field commands Add argument/option autocompletion to field commands Aug 4, 2023
@weitzman
Copy link
Member

weitzman commented Aug 4, 2023

Lgtm. Feel free to merge when satisfied.

@DieterHolvoet DieterHolvoet marked this pull request as ready for review August 7, 2023 09:53
@DieterHolvoet DieterHolvoet force-pushed the feature/field-command-completion branch from 33fdf58 to 61beaae Compare August 7, 2023 09:54
@DieterHolvoet DieterHolvoet merged commit 1d39b54 into drush-ops:12.x Aug 7, 2023
2 checks passed
@DieterHolvoet DieterHolvoet deleted the feature/field-command-completion branch August 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants