Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Assertion\Handle::register() #5852

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Replace usage of Assertion\Handle::register() #5852

merged 2 commits into from
Jan 13, 2024

Conversation

claudiu-cristea
Copy link
Member

@claudiu-cristea claudiu-cristea commented Jan 13, 2024 •
edited

Fixes #5734

@weitzman weitzman merged commit 79a5e6b into 12.x Jan 13, 2024
2 checks passed
@weitzman weitzman deleted the 5734-assertion-handle branch January 13, 2024 21:08
andypost
andypost reviewed Mar 9, 2024
View reviewed changes
src/Commands/core/CliCommands.php
// errors being triggered. This plays nicer with PsySH. Since we're
// using exceptions, turn error warnings off.
assert_options(ASSERT_EXCEPTION, true);
assert_options(ASSERT_WARNING, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have wrapper for PHP 8.3 https://php.watch/versions/8.3/assert-multiple-deprecations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypost andypost andypost left review comments

@damiankloip damiankloip Awaiting requested review from damiankloip damiankloip is a code owner

@weitzman weitzman Awaiting requested review from weitzman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove or replace usage of Assertion::handler
3 participants
@claudiu-cristea @andypost @weitzman