chore: fix ci

dsherret · Jun 15, 2023 · 382f0c8 · 382f0c8
1 parent cdb3c5c
commit 382f0c8
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,6 +23,8 @@ jobs:
       run: |
         npm ci
         npm run --workspaces build
+    - name: Type check
+      run: |
         npm run --workspaces --if-present ensure-no-project-compile-errors
     - name: Test
       run: |

diff --git a/deno/ts_morph.d.ts b/deno/ts_morph.d.ts
@@ -638,7 +638,10 @@ export declare class Project {
    * @param moduleName - The ambient module name with or without quotes.
    */
   getAmbientModuleOrThrow(moduleName: string, message?: string | (() => string)): Symbol;
-  /** Gets the ambient module symbols (ex. modules in the @types folder or node_modules). */
+  /**
+   * Gets the ambient module symbols (ex. modules in the
+   * @types folder or node_modules).
+   */
   getAmbientModules(): Symbol[];
   /** Saves all the unsaved source files to the file system and deletes all deleted files. */
   save(): Promise<void>;
@@ -719,9 +722,15 @@ export interface ProjectOptions {
   compilerOptions?: CompilerOptions;
   /** File path to the tsconfig.json file. */
   tsConfigFilePath?: string;
-  /** Whether to skip adding the source files from the specified tsconfig.json. @default false */
+  /**
+   * Whether to skip adding the source files from the specified tsconfig.json.
+   * @default false
+   */
   skipAddingFilesFromTsConfig?: boolean;
-  /** Skip resolving file dependencies when providing a ts config file path and adding the files from tsconfig. @default false */
+  /**
+   * Skip resolving file dependencies when providing a ts config file path and adding the files from tsconfig.
+   * @default false
+   */
   skipFileDependencyResolution?: boolean;
   /**
    * Skip loading the lib files. Unlike the compiler API, ts-morph does not load these
@@ -735,7 +744,10 @@ export interface ProjectOptions {
   libFolderPath?: string;
   /** Manipulation settings */
   manipulationSettings?: Partial<ManipulationSettings>;
-  /** Whether to use an in-memory file system. @default false */
+  /**
+   * Whether to use an in-memory file system.
+   * @default false
+   */
   useInMemoryFileSystem?: boolean;
   /**
    * Optional file system host. Useful for mocking access to the file system.
@@ -9595,7 +9607,10 @@ export declare class TypeChecker {
   private constructor();
   /** Gets the compiler's TypeChecker. */
   get compilerObject(): ts.TypeChecker;
-  /** Gets the ambient module symbols (ex. modules in the @types folder or node_modules). */
+  /**
+   * Gets the ambient module symbols (ex. modules in the
+   * @types folder or node_modules).
+   */
   getAmbientModules(): Symbol[];
   /**
    * Gets the apparent type of a type.

diff --git a/packages/ts-morph/lib/ts-morph.d.ts b/packages/ts-morph/lib/ts-morph.d.ts
@@ -638,7 +638,10 @@ export declare class Project {
    * @param moduleName - The ambient module name with or without quotes.
    */
   getAmbientModuleOrThrow(moduleName: string, message?: string | (() => string)): Symbol;
-  /** Gets the ambient module symbols (ex. modules in the @types folder or node_modules). */
+  /**
+   * Gets the ambient module symbols (ex. modules in the
+   * @types folder or node_modules).
+   */
   getAmbientModules(): Symbol[];
   /** Saves all the unsaved source files to the file system and deletes all deleted files. */
   save(): Promise<void>;
@@ -719,9 +722,15 @@ export interface ProjectOptions {
   compilerOptions?: CompilerOptions;
   /** File path to the tsconfig.json file. */
   tsConfigFilePath?: string;
-  /** Whether to skip adding the source files from the specified tsconfig.json. @default false */
+  /**
+   * Whether to skip adding the source files from the specified tsconfig.json.
+   * @default false
+   */
   skipAddingFilesFromTsConfig?: boolean;
-  /** Skip resolving file dependencies when providing a ts config file path and adding the files from tsconfig. @default false */
+  /**
+   * Skip resolving file dependencies when providing a ts config file path and adding the files from tsconfig.
+   * @default false
+   */
   skipFileDependencyResolution?: boolean;
   /**
    * Skip loading the lib files. Unlike the compiler API, ts-morph does not load these
@@ -735,7 +744,10 @@ export interface ProjectOptions {
   libFolderPath?: string;
   /** Manipulation settings */
   manipulationSettings?: Partial<ManipulationSettings>;
-  /** Whether to use an in-memory file system. @default false */
+  /**
+   * Whether to use an in-memory file system.
+   * @default false
+   */
   useInMemoryFileSystem?: boolean;
   /**
    * Optional file system host. Useful for mocking access to the file system.
@@ -9595,7 +9607,10 @@ export declare class TypeChecker {
   private constructor();
   /** Gets the compiler's TypeChecker. */
   get compilerObject(): ts.TypeChecker;
-  /** Gets the ambient module symbols (ex. modules in the @types folder or node_modules). */
+  /**
+   * Gets the ambient module symbols (ex. modules in the
+   * @types folder or node_modules).
+   */
   getAmbientModules(): Symbol[];
   /**
    * Gets the apparent type of a type.

diff --git a/packages/ts-morph/src/tests/compiler/ast/common/nodeTests.ts b/packages/ts-morph/src/tests/compiler/ast/common/nodeTests.ts
@@ -1484,6 +1484,8 @@ class MyClass {
         foundKinds.push(child.getKind());
         if (callback)
           return callback(child);
+        else
+          return undefined;
       });
       expect(foundKinds).to.deep.equal(expectedKinds);
       expect(returnValue).to.deep.equal(expectedReturnValue);

diff --git a/packages/ts-morph/tsconfig.common.json b/packages/ts-morph/tsconfig.common.json
@@ -12,8 +12,6 @@
     "noFallthroughCasesInSwitch": true,
     "noImplicitReturns": true,
     "stripInternal": true,
-    "typeRoots": ["node_modules/@types"],
-    "types": ["node", "mocha"],
     "downlevelIteration": true,
     "importHelpers": false
   },