fix: allow setType on binding patterns (#1380)

dsherret · Mar 16, 2023 · d58f238 · d58f238
1 parent dc1c1b4
commit d58f238
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/deno/ts_morph.js b/deno/ts_morph.js
@@ -10081,7 +10081,8 @@ function TypedNode(Base) {
             });
             return this;
             function getInsertPosWhenNoType(node) {
-                const identifier = node.getFirstChildByKindOrThrow(SyntaxKind.Identifier);
+                var _a;
+                let identifier = (_a = node.getFirstChildByKind(SyntaxKind.Identifier)) !== null && _a !== void 0 ? _a : node.getFirstChildIfKindOrThrow(SyntaxKind.ObjectBindingPattern, "A first child of the kind Identifier or ObjectBindingPattern was expected.");
                 const nextSibling = identifier.getNextSibling();
                 const insertAfterNode = isQuestionOrExclamation(nextSibling) ? nextSibling : identifier;
                 return insertAfterNode.getEnd();

diff --git a/packages/ts-morph/src/compiler/ast/base/TypedNode.ts b/packages/ts-morph/src/compiler/ast/base/TypedNode.ts
@@ -77,7 +77,13 @@ export function TypedNode<T extends Constructor<TypedNodeExtensionType>>(Base: T
       return this;
 
       function getInsertPosWhenNoType(node: Node) {
-        const identifier = node.getFirstChildByKindOrThrow(SyntaxKind.Identifier);
+        let identifier = node.getFirstChildByKind(SyntaxKind.Identifier) ?? node.getFirstChildByKind(
+          SyntaxKind.ArrayBindingPattern,
+        ) ?? node.getFirstChildIfKindOrThrow(
+          SyntaxKind.ObjectBindingPattern,
+          "A first child of the kind Identifier, ArrayBindingPattern, or ObjectBindingPattern was expected.",
+        );
+
         const nextSibling = identifier.getNextSibling();
         const insertAfterNode = isQuestionOrExclamation(nextSibling) ? nextSibling : identifier;
 

diff --git a/packages/ts-morph/src/tests/compiler/ast/base/typedNodeTests.ts b/packages/ts-morph/src/tests/compiler/ast/base/typedNodeTests.ts
@@ -102,6 +102,14 @@ describe("TypedNode", () => {
         doTest(`function Identifier(param, param2) {}`, "number", `function Identifier(param: number, param2) {}`);
       });
 
+      it("should set with object binding pattern", () => {
+        doTest(`function Identifier({ foo }) {}`, "Record<string, any>", `function Identifier({ foo }: Record<string, any>) {}`);
+      });
+
+      it("should set with array binding pattern", () => {
+        doTest(`function Identifier([foo]) {}`, "number[]", `function Identifier([foo]: number[]) {}`);
+      });
+
       it("should set when explicit", () => {
         doTest(`function Identifier(param: string) {}`, "number", `function Identifier(param: number) {}`);
       });