Reject empty string in Tag::new

dtolnay · Apr 6, 2023 · c1ea51c · c1ea51c
1 parent f833329
commit c1ea51c
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/value/tagged.rs b/src/value/tagged.rs
@@ -79,10 +79,15 @@ impl Tag {
     ///
     /// Such a tag would serialize to `!Thing` in YAML regardless of whether a
     /// '!' was included in the call to `Tag::new`.
+    ///
+    /// # Panics
+    ///
+    /// Panics if `string.is_empty()`. There is no syntax in YAML for an empty
+    /// tag.
     pub fn new(string: impl Into<String>) -> Self {
-        Tag {
-            string: string.into(),
-        }
+        let tag: String = string.into();
+        assert!(!tag.is_empty(), "empty YAML tag is not allowed");
+        Tag { string: tag }
     }
 }