Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Add seeded versions of deserialize functions. #135

Merged
merged 1 commit into from Oct 4, 2019
Merged

Add seeded versions of deserialize functions. #135

merged 1 commit into from Oct 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 12, 2019

Allows usage of DeserializeSeed types.

The T parameters on _seed functions are required because it's not possible to extract S::Value out of the higher-rank bound without also specifying that for all 'de, S::Value is indeed the same type.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you please move the new functions to a serde_yaml::seed module? These are going to be pretty niche so I would prefer that they don't appear as a distraction in the top level rustdoc view.

src/de.rs Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Sep 16, 2019

All done!

@ghost ghost requested a review from dtolnay September 24, 2019 06:24
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dtolnay dtolnay merged commit 14ea96f into dtolnay:master Oct 4, 2019
@dtolnay
Copy link
Owner

dtolnay commented Oct 5, 2019

Published in serde_yaml 0.8.11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant