Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in proc-macro2 1.0.46 for byte order mark fix #1226

Merged
merged 1 commit into from Sep 29, 2022
Merged

Pull in proc-macro2 1.0.46 for byte order mark fix #1226

merged 1 commit into from Sep 29, 2022

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Sep 29, 2022

See dtolnay/proc-macro2#353.

Without this, our benchmarks fail against the current contents of the rust-lang/rust repo.

$ cargo test --release --bench rust --features full,test
871050 lines in 12914 files
read_from_disk:     elapsed=0.170s
tokenstream_parse:  FAIL tests/rust/src/test/ui/json/json-bom-plus-crlf-multifile-aux.rs
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `12913`,
 right: `12914`', benches/rust.rs:122:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Without this, our benchmarks fail against the current contents of the
rust-lang/rust repo.

    $ cargo test --release --bench rust --features full,test
    871050 lines in 12914 files
    read_from_disk:     elapsed=0.170s
    tokenstream_parse:  FAIL tests/rust/src/test/ui/json/json-bom-plus-crlf-multifile-aux.rs
    thread 'main' panicked at 'assertion failed: `(left == right)`
      left: `12913`,
     right: `12914`', benches/rust.rs:122:5
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@dtolnay dtolnay merged commit 296e046 into master Sep 29, 2022
@dtolnay dtolnay deleted the bom branch September 29, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant