Merge pull request #115 from dtolnay/lifetime

Add justification to non-static lifetime diagnostic
dtolnay · Dec 27, 2020 · cb3077c · cb3077c
2 parents a789be4 + d31d96b
commit cb3077c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/impl/src/valid.rs b/impl/src/valid.rs
@@ -190,8 +190,8 @@ fn check_field_attrs(fields: &[Field]) -> Result<()> {
     if let Some(source_field) = source_field.or(from_field) {
         if contains_non_static_lifetime(source_field) {
             return Err(Error::new_spanned(
-                source_field.original,
-                "non-static lifetimes are not allowed in the source of an error",
+                &source_field.original.ty,
+                "non-static lifetimes are not allowed in the source of an error, because std::error::Error requires the source is dyn Error + 'static",
             ));
         }
     }

diff --git a/tests/ui/lifetime.stderr b/tests/ui/lifetime.stderr
@@ -1,5 +1,5 @@
-error: non-static lifetimes are not allowed in the source of an error
- --> $DIR/lifetime.rs:5:18
+error: non-static lifetimes are not allowed in the source of an error, because std::error::Error requires the source is dyn Error + 'static
+ --> $DIR/lifetime.rs:5:26
   |
 5 | struct Error<'a>(#[from] Inner<'a>);
-  |                  ^^^^^^^^^^^^^^^^^
+  |                          ^^^^^^^^^