Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Script update:examples should not fail on updates #1022

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Sep 29, 2020

In a nutshell

❌ New feature
❌ Fix an issue
βœ”οΈ Documentation improvement
❌ Other: please explain

(βœ”οΈ: yes, ❌: no)

Potential impacts

None

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70a5e62:

Sandbox Source
Vanilla Configuration
dubzzz/fast-check: example Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Sep 29, 2020

Rq:

  • yarn e2e will still fail
  • yarn update:examples will not fail and will update the doc

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.332% when pulling 70a5e62 on do-not-fail-when-updating-the-doc into ee89940 on master.

@dubzzz dubzzz merged commit 334dce6 into master Sep 29, 2020
@dubzzz dubzzz deleted the do-not-fail-when-updating-the-doc branch September 29, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants