Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’š Safer URL validation in our web urls e2e tests #1236

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Dec 9, 2020

In a nutshell

Fixes #1235

❌ New feature
❌ Fix an issue
❌ Documentation improvement
βœ”οΈ Other: wrong test

(βœ”οΈ: yes, ❌: no)

Potential impacts

None

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6dee89b:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@coveralls
Copy link

coveralls commented Dec 9, 2020 β€’

Coverage Status

Coverage remained the same at 96.669% when pulling 6dee89b on fix-invalid-weburl-tests into 46d8b51 on master.

@dubzzz dubzzz merged commit fcf23ed into master Dec 9, 2020
@dubzzz dubzzz deleted the fix-invalid-weburl-tests branch December 9, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some web arbitraries seem to produce invalid urls in rare cases
2 participants