Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Remove unused flags in coverage #1290

Merged
merged 2 commits into from
Dec 28, 2020
Merged

👷 Remove unused flags in coverage #1290

merged 2 commits into from
Dec 28, 2020

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Dec 28, 2020

In a nutshell

For the moment, we don't use flags so much. So we limit them to the name of the job. We might add them back in the future of needed.

❌ New feature
❌ Fix an issue
❌ Documentation improvement
✔️ Other: code coverage

(✔️: yes, ❌: no)

Potential impacts

None

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5810606:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1290 (5810606) into master (bdcd9ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          89       89           
  Lines        2902     2902           
  Branches      533      533           
=======================================
  Hits         2866     2866           
  Misses         33       33           
  Partials        3        3           
Flag Coverage Δ
Linux ?
Windows ?
e2e-tests 90.07% <ø> (ø)
e2e-tests-10.x-Linux 90.04% <ø> (ø)
e2e-tests-10.x-Windows 88.00% <ø> (-0.11%) ⬇️
e2e-tests-10.x-macOS 90.04% <ø> (-0.04%) ⬇️
e2e-tests-12.x-Linux 90.04% <ø> (ø)
e2e-tests-12.x-Windows 88.07% <ø> (-0.11%) ⬇️
e2e-tests-12.x-macOS 90.07% <ø> (+0.06%) ⬆️
e2e-tests-14.x-Linux 90.04% <ø> (ø)
e2e-tests-14.x-Windows 87.97% <ø> (-0.25%) ⬇️
e2e-tests-14.x-macOS 90.04% <ø> (-0.04%) ⬇️
macOS ?
node-10.x ?
node-12.x ?
node-14.x ?
unit-tests 97.76% <ø> (ø)
unit-tests-10.x-Linux 97.76% <ø> (ø)
unit-tests-12.x-Linux 97.76% <ø> (ø)
unit-tests-14.x-Linux 97.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcd9ac...5810606. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 28, 2020

Coverage Status

Coverage remained the same at 96.877% when pulling 5810606 on dubzzz-patch-3 into bdcd9ac on master.

@dubzzz dubzzz merged commit ca84911 into master Dec 28, 2020
@dubzzz dubzzz deleted the dubzzz-patch-3 branch December 28, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants