Skip to content

✨ Properly handle objects with symbols as keys in fc.stringify #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 6, 2021

In a nutshell

✔️ New feature
❌ Fix an issue
❌ Documentation improvement
❌ Other: please explain

(✔️: yes, ❌: no)

Potential impacts

None

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

Give a try to 311ce5b with:

yarn add https://pkg.csb.dev/dubzzz/fast-check/commit/311ce5b3/fast-check
npm i https://pkg.csb.dev/dubzzz/fast-check/commit/311ce5b3/fast-check

⚠️ Package might not be accessible yet. Wait for CodeSandbox.

⚠️ By running one of these commands you will install the package defined by the head of the PR. But, tests are run against the result of the merge of the PR, not against the head of the PR*. *If needed, you can install the package used for the tests by manually retrieving and installing the artifact bundle stored into GitHub Actions.

Useful links: Codeclimate, Codecov, CodeSandbox and GitHub Actions.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bd91014:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #1327 (bd91014) into master (e38c0bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1327   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          89       89           
  Lines        2917     2926    +9     
  Branches      542      546    +4     
=======================================
+ Hits         2881     2890    +9     
  Misses         33       33           
  Partials        3        3           
Flag Coverage Δ
e2e-tests 89.71% <54.54%> (-0.14%) ⬇️
e2e-tests-10.x-Linux 89.67% <54.54%> (-0.18%) ⬇️
e2e-tests-10.x-Windows 87.83% <54.54%> (-0.10%) ⬇️
e2e-tests-10.x-macOS 89.71% <54.54%> (-0.11%) ⬇️
e2e-tests-12.x-Linux 89.71% <54.54%> (-0.11%) ⬇️
e2e-tests-12.x-Windows 87.73% <54.54%> (+<0.01%) ⬆️
e2e-tests-12.x-macOS 89.67% <54.54%> (-0.18%) ⬇️
e2e-tests-14.x-Linux 89.67% <54.54%> (-0.14%) ⬇️
e2e-tests-14.x-Windows 87.86% <54.54%> (-0.10%) ⬇️
e2e-tests-14.x-macOS 89.71% <54.54%> (-0.14%) ⬇️
unit-tests 97.74% <100.00%> (+<0.01%) ⬆️
unit-tests-10.x-Linux 97.71% <100.00%> (+<0.01%) ⬆️
unit-tests-12.x-Linux 97.74% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 97.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/stringify.ts 98.94% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38c0bd...bd91014. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

Give a try to 090e0c5 with:

yarn add https://pkg.csb.dev/dubzzz/fast-check/commit/090e0c57/fast-check
npm i https://pkg.csb.dev/dubzzz/fast-check/commit/090e0c57/fast-check

⚠️ Package might not be accessible yet. Wait for CodeSandbox.

⚠️ By running one of these commands you will install the package defined by the head of the PR. But, tests are run against the result of the merge of the PR, not against the head of the PR*. *If needed, you can install the package used for the tests by manually retrieving and installing the artifact bundle stored into GitHub Actions.

Useful links: Codeclimate, Codecov, CodeSandbox and GitHub Actions.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

Give a try to bd91014 with:

yarn add https://pkg.csb.dev/dubzzz/fast-check/commit/bd910141/fast-check
npm i https://pkg.csb.dev/dubzzz/fast-check/commit/bd910141/fast-check

⚠️ Package might not be accessible yet. Wait for CodeSandbox.

⚠️ By running one of these commands you will install the package defined by the head of the PR. But, tests are run against the result of the merge of the PR, not against the head of the PR*. *If needed, you can install the package used for the tests by manually retrieving and installing the artifact bundle stored into GitHub Actions.

Useful links: Codeclimate, Codecov, CodeSandbox and GitHub Actions.

@dubzzz dubzzz merged commit 16141b0 into master Jan 6, 2021
@dubzzz dubzzz deleted the stringify-obj branch January 6, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant