Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘· Ignore version bump checks on publish #3354

Merged
merged 1 commit into from Oct 23, 2022
Merged

πŸ‘· Ignore version bump checks on publish #3354

merged 1 commit into from Oct 23, 2022

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 23, 2022

No need to check if versions have been properly marked as bumped on publish. If publish task has been triggered then everything is ok.

The only case that was problematic today was when trying to publish from non main branches (backport case).

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

No need to check if versions have been properly marked as bumped on publish. If publish task has been triggered then everything is ok.

The only case that was problematic today was when trying to publish from non main branches (backport case).
@dubzzz dubzzz merged commit 68af330 into main Oct 23, 2022
@dubzzz dubzzz deleted the dubzzz-patch-4 branch October 23, 2022 19:59
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87ab6cd:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant