Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Drop useless internal stream conversions #3553

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 15, 2023

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 293c05f:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 15, 2023

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #3553 (293c05f) into main (078eb14) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #3553      +/-   ##
==========================================
- Coverage   95.47%   95.45%   -0.02%     
==========================================
  Files         213      213              
  Lines        5897     5896       -1     
  Branches     1095     1095              
==========================================
- Hits         5630     5628       -2     
- Misses        267      268       +1     
Flag Coverage Δ
unit-tests 95.45% <88.88%> (-0.02%) ⬇️
unit-tests-14.x-Linux ?
unit-tests-16.x-Linux ?
unit-tests-18.x-Linux 95.45% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/fast-check/src/check/runner/utils/PathWalker.ts 94.11% <80.00%> (-0.33%) ⬇️
packages/fast-check/src/check/runner/Runner.ts 95.89% <100.00%> (ø)
packages/fast-check/src/arbitrary/double.ts 97.50% <0.00%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dubzzz dubzzz merged commit cfab900 into main Jan 15, 2023
@dubzzz dubzzz deleted the drop-unneeded-stream branch January 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant