⚡️ Tosser must immediately produce values #3554

dubzzz · 2023-01-15T17:04:21Z

...instead of producing generators that will be called to produce the values.

Category:

Potential impacts:

...instead of producing generators that will be call to produce the values.

packages/fast-check/src/check/runner/Sampler.ts

codesandbox-ci · 2023-01-15T17:08:07Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f280ec4:

Sandbox	Source
Vanilla	Configuration
@fast-check/examples	Configuration

packages/fast-check/src/check/runner/Runner.ts

packages/fast-check/test/unit/check/runner/SourceValuesIterator.spec.ts

…r.spec.ts

…sIterator.spec.ts" This reverts commit a983cc1.

This reverts commit b3039e8.

The original attempt to optimize the performance of tosser introduced a slightly regression in the code. It broke many replays capabilities. Regression introduced by #3554. Fix #3613

* 🐛 Fix broken replay based on path The original attempt to optimize the performance of tosser introduced a slightly regression in the code. It broke many replays capabilities. Regression introduced by #3554. Fix #3613 * versions

⚡️ Tosser must immediately produce values

c32fa1a

...instead of producing generators that will be call to produce the values.

dubzzz commented Jan 15, 2023

View reviewed changes

packages/fast-check/src/check/runner/Sampler.ts Outdated Show resolved Hide resolved

dubzzz added 2 commits January 15, 2023 18:05

Update packages/fast-check/src/check/runner/Sampler.ts

62c2e8c

versions

2acbfc4

fix code and compile

438e3e0

dubzzz commented Jan 15, 2023

View reviewed changes

packages/fast-check/src/check/runner/Runner.ts Outdated Show resolved Hide resolved

packages/fast-check/src/check/runner/Runner.ts Outdated Show resolved Hide resolved

dubzzz added 3 commits January 15, 2023 18:50

Update packages/fast-check/src/check/runner/Runner.ts

e33351c

Update packages/fast-check/src/check/runner/Runner.ts

636cef5

Update SourceValuesIterator.spec.ts

b3039e8

dubzzz commented Jan 15, 2023

View reviewed changes

packages/fast-check/test/unit/check/runner/SourceValuesIterator.spec.ts Outdated Show resolved Hide resolved

dubzzz added 7 commits January 15, 2023 22:24

Update packages/fast-check/test/unit/check/runner/SourceValuesIterato…

a983cc1

…r.spec.ts

Revert "Update packages/fast-check/test/unit/check/runner/SourceValue…

60ee17e

…sIterator.spec.ts" This reverts commit a983cc1.

Revert "Update SourceValuesIterator.spec.ts"

d060a34

This reverts commit b3039e8.

fix tests

29cdb39

rework sampler

2c999dc

move back to toss

f7585dc

directly pass path

f280ec4

dubzzz merged commit 7b89487 into main Jan 16, 2023

dubzzz deleted the toss-produce-values-not-generators branch January 16, 2023 08:51

dubzzz mentioned this pull request Feb 7, 2023

Replay issue detected during unit #3613

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

⚡️ Tosser must immediately produce values #3554

⚡️ Tosser must immediately produce values #3554

dubzzz commented Jan 15, 2023 •

edited

Loading

codesandbox-ci bot commented Jan 15, 2023 •

edited

Loading

⚡️ Tosser must immediately produce values #3554

⚡️ Tosser must immediately produce values #3554

Conversation

dubzzz commented Jan 15, 2023 • edited Loading

codesandbox-ci bot commented Jan 15, 2023 • edited Loading

dubzzz commented Jan 15, 2023 •

edited

Loading

codesandbox-ci bot commented Jan 15, 2023 •

edited

Loading