Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Drop bailout linked to toss #3564

Merged
merged 7 commits into from
Jan 19, 2023
Merged

⚡️ Drop bailout linked to toss #3564

merged 7 commits into from
Jan 19, 2023

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 18, 2023

The following optim mostly address performance issues related to toss in the case of no examples. While examples can be a legit usage, we have not covered it i this optimization (yield* not being optimized a lot as it triggers bailout).

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

The following optim mostly address performance issues related to toss in the case of no examples. While examples can be a legit usage, we have not covered it i this optimization (yield* not being optimized a lot as it triggers bailout).
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0747b26:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #3564 (0747b26) into main (c94a967) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3564   +/-   ##
=======================================
  Coverage   95.67%   95.68%           
=======================================
  Files         201      201           
  Lines        5185     5188    +3     
  Branches     1105     1105           
=======================================
+ Hits         4961     4964    +3     
  Misses        215      215           
  Partials        9        9           
Flag Coverage Δ
unit-tests 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-16.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-check/src/arbitrary/_internals/TupleArbitrary.ts 98.36% <100.00%> (+0.05%) ⬆️
packages/fast-check/src/check/runner/Tosser.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 19, 2023

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 19, 2023

Performance benefits seem low or not there. I'll rather kill some parts causing bailouts and not fix all of them. It seems that after several bailouts the toss function finally makes it to an optimized version. The only piece remaining and causing bailout will be the examples part of toss (even if no examples).

@dubzzz
Copy link
Owner Author

dubzzz commented Jan 19, 2023

@dubzzz dubzzz merged commit 312e72f into main Jan 19, 2023
@dubzzz dubzzz deleted the drop-bailout branch January 19, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant