Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Fix broken replay based on path #3617

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 7, 2023

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

The original attempt to optimize the performance of tosser introduced a slightly regression in the code. It broke many replays capabilities.

Regression introduced by #3554.

Fix #3613
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db5316e:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@codecov
Copy link

codecov bot commented Feb 7, 2023 β€’

Codecov Report

Merging #3617 (db5316e) into main (8da17cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3617   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files         201      201           
  Lines        5195     5197    +2     
  Branches     1105     1105           
=======================================
+ Hits         4971     4973    +2     
  Misses        215      215           
  Partials        9        9           
Flag Coverage Ξ”
unit-tests 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-14.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-16.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x-Linux 95.68% <100.00%> (+<0.01%) ⬆️
unit-tests-latest-Linux 95.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/fast-check/src/check/runner/Tosser.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dubzzz dubzzz merged commit 998a8a0 into main Feb 7, 2023
@dubzzz dubzzz deleted the fix-regression-replay branch February 7, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant