Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Drop website build on build:all #3744

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 11, 2023

Building the website for the documentation has already a dedicated step in the workflow. No need to build it twice. Additionally it's one of the most costly package to build so worth dropping it from fast paths.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Building the website for the documentation has already a dedicated step in the workflow. No need to build it twice. Additionally it's one of the most costly package to build so worth dropping it from fast paths.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 470d9ad:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3744 (470d9ad) into main (0b29b13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3744   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         205      205           
  Lines        5303     5303           
  Branches     1119     1119           
=======================================
  Hits         5046     5046           
  Misses        241      241           
  Partials       16       16           
Flag Coverage Δ
unit-tests 95.15% <ø> (ø)
unit-tests-14.x-Linux ?
unit-tests-16.x-Linux ?
unit-tests-18.x-Linux 95.15% <ø> (ø)
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dubzzz dubzzz merged commit 20c421e into main Apr 11, 2023
66 checks passed
@dubzzz dubzzz deleted the no-website-build-on-build branch April 11, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant