-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ability to customize act
per call
#3889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `act` is the only way to make sure we can wrap some extra logic around the piece of code firing continuations of the awaited task. It proves pretty useful in React contexts (and not only) as such contexts need to explicitely run some operations in very specific contexts. In the case of React tests, updates of states have to be performed in `act` context. This argument makes it possible for the users to specify per scheduled task how they should be wrapped. Up-to-now the `act` was only configurable globally without any by-site customization.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 190339f:
|
dubzzz
commented
May 18, 2023
dubzzz
commented
May 18, 2023
12 tasks
dubzzz
added a commit
that referenced
this pull request
May 18, 2023
* ✨ Add ability to customize `act` per wait Follow-up of #3889 * versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
act
is the only way to make sure we can wrap some extra logic around the piece of code firing continuations of the awaited task.It proves pretty useful in React contexts (and not only) as such contexts need to explicitely run some operations in very specific contexts. In the case of React tests, updates of states have to be performed in
act
context. This argument makes it possible for the users to specify per scheduled task how they should be wrapped. Up-to-now theact
was only configurable globally without any by-site customization.Category:
Potential impacts: