🔥 Drop bundle centric tests #3909
Merged
+13
−1,208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fast-check was alone in the repository and while we strated to experience our first issues linked to bundling, we added a set of specs responsible to check our bundling against several well-known bundler. While useful in the past while we highly worked on this specific area, it proved less and less useful over time and started to consume many runners for not that much output. So we dropped legacy checks in favor of a very simple and basic bundle check.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9a183b:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ceeac33:
|
Codecov Report
@@ Coverage Diff @@
## main #3909 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 205 205
Lines 5314 5314
Branches 1123 1123
=======================================
Hits 5057 5057
Misses 241 241
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fast-check was alone in the repository and while we strated to experience our first issues linked to bundling, we added a set of specs responsible to check our bundling against several well-known bundler. While useful in the past while we highly worked on this specific area, it proved less and less useful over time and started to consume many runners for not that much output.
So we dropped legacy checks in favor of a very simple and basic bundle check.
Category:
Potential impacts: