✨ Prepare tokenizers for stringMatching
#3920
Merged
+592
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to implement a `stringMatching` arbitrary as requested in #2980, we first need to be able to understand a regex. Understanding a regex can be achieved by tokenizing it. This first adds a basic tokenizer of regex that will be able to read a regex and translate it into an AST. This AST will be the entry point of our `stringMatching`. So far our tokenizer performs poorly for squared-bracket or parenthesis expresssions. But work is on-going to full support them. --- We initially not wanted to go for regex as they were too rich and thus would have requested lost of stuff to be implemented and carefully check, but as globs were not really designed for string matching topic, we went back to it.
dubzzz
changed the title
stringMatching
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f2a9c8:
|
Codecov Report
@@ Coverage Diff @@
## main #3920 +/- ##
==========================================
- Coverage 95.16% 94.92% -0.24%
==========================================
Files 205 207 +2
Lines 5314 5560 +246
Branches 1123 1230 +107
==========================================
+ Hits 5057 5278 +221
- Misses 241 266 +25
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to implement a
stringMatchingarbitrary as requested in #2980, we first need to be able to understand a regex. Understanding a regex can be achieved by tokenizing it.This first adds a basic tokenizer of regex that will be able to read a regex and translate it into an AST. This AST will be the entry point of our
stringMatching. So far our tokenizer performs poorly for squared-bracket or parenthesis expressions and also unicode mode. But work is on-going to full support them.Category:
Potential impacts:
We initially not wanted to go for regex as they were too rich and thus would have requested lost of stuff to be implemented and carefully check, but as globs were not really designed for string matching topic, we went back to it.