Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Explicit ban of unsupported regex flags in stringMatching #3925

Merged
merged 2 commits into from
May 29, 2023

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 29, 2023

Many flags on regexes are not supported by stringMatching at the moment. Instead of letting users detect the issues, we reject before generating anything to make it clear. Support for some of them will come as we enrich this feature.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

dubzzz added 2 commits May 29, 2023 17:50
Many flags on regexes are not supported by `stringMatching` at the moment. Instead of letting users detect the issues, we reject before generating anything to make it clear. Support for some of them will come as we enrich this feature.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9635630:

Sandbox Source
Vanilla Configuration

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #3925 (9635630) into main (6cabbeb) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
- Coverage   94.78%   94.78%   -0.01%     
==========================================
  Files         208      208              
  Lines        5635     5634       -1     
  Branches     1259     1258       -1     
==========================================
- Hits         5341     5340       -1     
+ Misses        278      277       -1     
- Partials       16       17       +1     
Flag Coverage Δ
unit-tests 94.78% <33.33%> (-0.01%) ⬇️
unit-tests-14.x-Linux 94.78% <33.33%> (-0.01%) ⬇️
unit-tests-16.x-Linux 94.78% <33.33%> (-0.01%) ⬇️
unit-tests-18.x-Linux 94.78% <33.33%> (-0.01%) ⬇️
unit-tests-latest-Linux 94.78% <33.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/fast-check/src/arbitrary/stringMatching.ts 80.55% <33.33%> (-0.27%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant